cardosofelipe/fast-next-template
Template
1
0
Fork 1
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

fix: Comprehensive validation and bug fixes

Browse Source 
Infrastructure:
- Add Redis and Celery workers to all docker-compose files
- Fix celery migration race condition in entrypoint.sh
- Add healthchecks and resource limits to dev compose
- Update .env.template with Redis/Celery variables

Backend Models & Schemas:
- Rename Sprint.completed_points to velocity (per requirements)
- Add AgentInstance.name as required field
- Rename Issue external tracker fields for consistency
- Add IssueSource and TrackerType enums
- Add Project.default_tracker_type field

Backend Fixes:
- Add Celery retry configuration with exponential backoff
- Remove unused sequence counter from EventBus
- Add mypy overrides for test dependencies
- Fix test file using wrong schema (UserUpdate -> dict)

Frontend Fixes:
- Fix memory leak in useProjectEvents (proper cleanup)
- Fix race condition with stale closure in reconnection
- Sync TokenWithUser type with regenerated API client
- Fix expires_in null handling in useAuth
- Clean up unused imports in prototype pages
- Add ESLint relaxed rules for prototype files

CI/CD:
- Add E2E testing stage with Testcontainers
- Add security scanning with Trivy and pip-audit
- Add dependency caching for faster builds

Tests:
- Update all tests to use renamed fields (velocity, name, etc.)
- Fix 14 schema test failures
- All 1500 tests pass with 91% coverage

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Felipe Cardoso
2025-12-30 10:35:30 +01:00
parent 6ea9edf3d1
commit 742ce4c9c8
57 changed files with 1062 additions and 332 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
backend/app/alembic/versions/0001_initial_models.py
View File

@@ -1,21 +1,21 @@
"""initial models
Revision ID: 0001
Revises:
Revises:
Create Date: 2025-11-27 09:08:09.464506
"""
from typing import Sequence, Union
from collections.abc import Sequence
from alembic import op
import sqlalchemy as sa
from alembic import op
from sqlalchemy.dialects import postgresql
# revision identifiers, used by Alembic.
revision: str = '0001'
down_revision: Union[str, None] = None
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None
down_revision: str | None = None
branch_labels: str | Sequence[str] | None = None
depends_on: str | Sequence[str] | None = None
def upgrade() -> None:

6
backend/app/celery_app.py
View File

@@ -64,6 +64,12 @@ celery_app.conf.update(
result_expires=86400,
# Broker connection retry
broker_connection_retry_on_startup=True,
# Retry configuration per ADR-003 (built-in retry with backoff)
task_autoretry_for=(Exception,), # Retry on all exceptions
task_retry_kwargs={"max_retries": 3, "countdown": 5}, # Initial 5s delay
task_retry_backoff=True, # Enable exponential backoff
task_retry_backoff_max=600, # Max 10 minutes between retries
task_retry_jitter=True, # Add jitter to prevent thundering herd
# Beat schedule for periodic tasks
beat_schedule={
# Cost aggregation every hour per ADR-012

1
backend/app/crud/syndarix/agent_instance.py
View File

@@ -31,6 +31,7 @@ class CRUDAgentInstance(CRUDBase[AgentInstance, AgentInstanceCreate, AgentInstan
db_obj = AgentInstance(
agent_type_id=obj_in.agent_type_id,
project_id=obj_in.project_id,
name=obj_in.name,
status=obj_in.status,
current_task=obj_in.current_task,
short_term_memory=obj_in.short_term_memory,

20
backend/app/crud/syndarix/issue.py
View File

@@ -36,10 +36,10 @@ class CRUDIssue(CRUDBase[Issue, IssueCreate, IssueUpdate]):
human_assignee=obj_in.human_assignee,
sprint_id=obj_in.sprint_id,
story_points=obj_in.story_points,
external_tracker=obj_in.external_tracker,
external_id=obj_in.external_id,
external_url=obj_in.external_url,
external_number=obj_in.external_number,
external_tracker_type=obj_in.external_tracker_type,
external_issue_id=obj_in.external_issue_id,
remote_url=obj_in.remote_url,
external_issue_number=obj_in.external_issue_number,
sync_status=SyncStatus.SYNCED,
)
db.add(db_obj)
@@ -389,21 +389,21 @@ class CRUDIssue(CRUDBase[Issue, IssueCreate, IssueUpdate]):
self,
db: AsyncSession,
*,
external_tracker: str,
external_id: str,
external_tracker_type: str,
external_issue_id: str,
) -> Issue | None:
"""Get an issue by its external tracker ID."""
try:
result = await db.execute(
select(Issue).where(
Issue.external_tracker == external_tracker,
Issue.external_id == external_id,
Issue.external_tracker_type == external_tracker_type,
Issue.external_issue_id == external_issue_id,
)
)
return result.scalar_one_or_none()
except Exception as e:
logger.error(
f"Error getting issue by external ID {external_tracker}:{external_id}: {e!s}",
f"Error getting issue by external ID {external_tracker_type}:{external_issue_id}: {e!s}",
exc_info=True,
)
raise
@@ -418,7 +418,7 @@ class CRUDIssue(CRUDBase[Issue, IssueCreate, IssueUpdate]):
"""Get issues that need to be synced with external tracker."""
try:
query = select(Issue).where(
Issue.external_tracker.isnot(None),
Issue.external_tracker_type.isnot(None),
Issue.sync_status.in_([SyncStatus.PENDING, SyncStatus.ERROR]),
)

14
backend/app/crud/syndarix/sprint.py
View File

@@ -34,7 +34,7 @@ class CRUDSprint(CRUDBase[Sprint, SprintCreate, SprintUpdate]):
end_date=obj_in.end_date,
status=obj_in.status,
planned_points=obj_in.planned_points,
completed_points=obj_in.completed_points,
velocity=obj_in.velocity,
)
db.add(db_obj)
await db.commit()
@@ -246,14 +246,14 @@ class CRUDSprint(CRUDBase[Sprint, SprintCreate, SprintUpdate]):
sprint.status = SprintStatus.COMPLETED
# Calculate completed points from closed issues
# Calculate velocity (completed points) from closed issues
points_result = await db.execute(
select(func.sum(Issue.story_points)).where(
Issue.sprint_id == sprint_id,
Issue.status == IssueStatus.CLOSED,
)
)
sprint.completed_points = points_result.scalar_one_or_none() or 0
sprint.velocity = points_result.scalar_one_or_none() or 0
await db.commit()
await db.refresh(sprint)
@@ -317,16 +317,16 @@ class CRUDSprint(CRUDBase[Sprint, SprintCreate, SprintUpdate]):
velocity_data = []
for sprint in reversed(sprints): # Return in chronological order
velocity = None
velocity_ratio = None
if sprint.planned_points and sprint.planned_points > 0:
velocity = (sprint.completed_points or 0) / sprint.planned_points
velocity_ratio = (sprint.velocity or 0) / sprint.planned_points
velocity_data.append(
{
"sprint_number": sprint.number,
"sprint_name": sprint.name,
"planned_points": sprint.planned_points,
"completed_points": sprint.completed_points,
"velocity": velocity,
"velocity": sprint.velocity,
"velocity_ratio": velocity_ratio,
}
)

22
backend/app/models/__init__.py
View File

@@ -18,11 +18,6 @@ from .oauth_provider_token import OAuthConsent, OAuthProviderRefreshToken
from .oauth_state import OAuthState
from .organization import Organization
# Import models
from .user import User
from .user_organization import OrganizationRole, UserOrganization
from .user_session import UserSession
# Syndarix domain models
from .syndarix import (
AgentInstance,
@@ -32,8 +27,17 @@ from .syndarix import (
Sprint,
)
# Import models
from .user import User
from .user_organization import OrganizationRole, UserOrganization
from .user_session import UserSession
__all__ = [
# Syndarix models
"AgentInstance",
"AgentType",
"Base",
"Issue",
"OAuthAccount",
"OAuthAuthorizationCode",
"OAuthClient",
@@ -42,15 +46,11 @@ __all__ = [
"OAuthState",
"Organization",
"OrganizationRole",
"Project",
"Sprint",
"TimestampMixin",
"UUIDMixin",
"User",
"UserOrganization",
"UserSession",
# Syndarix models
"AgentInstance",
"AgentType",
"Issue",
"Project",
"Sprint",
]

6
backend/app/models/syndarix/__init__.py
View File

@@ -15,8 +15,11 @@ from .agent_type import AgentType
from .enums import (
AgentStatus,
AutonomyLevel,
ClientMode,
IssuePriority,
IssueStatus,
IssueType,
ProjectComplexity,
ProjectStatus,
SprintStatus,
SyncStatus,
@@ -30,10 +33,13 @@ __all__ = [
"AgentStatus",
"AgentType",
"AutonomyLevel",
"ClientMode",
"Issue",
"IssuePriority",
"IssueStatus",
"IssueType",
"Project",
"ProjectComplexity",
"ProjectStatus",
"Sprint",
"SprintStatus",

5
backend/app/models/syndarix/agent_instance.py
View File

@@ -57,6 +57,9 @@ class AgentInstance(Base, UUIDMixin, TimestampMixin):
index=True,
)
# Agent instance name (e.g., "Dave", "Eve") for personality
name = Column(String(100), nullable=False, index=True)
# Status tracking
status: Column[AgentStatus] = Column(
Enum(AgentStatus),
@@ -103,6 +106,6 @@ class AgentInstance(Base, UUIDMixin, TimestampMixin):
def __repr__(self) -> str:
return (
f"<AgentInstance {self.id} type={self.agent_type_id} "
f"<AgentInstance {self.name} ({self.id}) type={self.agent_type_id} "
f"project={self.project_id} status={self.status.value}>"
)

46
backend/app/models/syndarix/enums.py
View File

@@ -23,6 +23,34 @@ class AutonomyLevel(str, PyEnum):
AUTONOMOUS = "autonomous"
class ProjectComplexity(str, PyEnum):
"""
Project complexity level for estimation and planning.
SCRIPT: Simple automation or script-level work
SIMPLE: Straightforward feature or fix
MEDIUM: Standard complexity with some architectural considerations
COMPLEX: Large-scale feature requiring significant design work
"""
SCRIPT = "script"
SIMPLE = "simple"
MEDIUM = "medium"
COMPLEX = "complex"
class ClientMode(str, PyEnum):
"""
How the client prefers to interact with agents.
TECHNICAL: Client is technical and prefers detailed updates
AUTO: Agents automatically determine communication level
"""
TECHNICAL = "technical"
AUTO = "auto"
class ProjectStatus(str, PyEnum):
"""
Project lifecycle status.
@@ -57,6 +85,22 @@ class AgentStatus(str, PyEnum):
TERMINATED = "terminated"
class IssueType(str, PyEnum):
"""
Issue type for categorization and hierarchy.
EPIC: Large feature or body of work containing stories
STORY: User-facing feature or requirement
TASK: Technical work item
BUG: Defect or issue to be fixed
"""
EPIC = "epic"
STORY = "story"
TASK = "task"
BUG = "bug"
class IssueStatus(str, PyEnum):
"""
Issue workflow status.
@@ -113,11 +157,13 @@ class SprintStatus(str, PyEnum):
PLANNED: Sprint has been created but not started
ACTIVE: Sprint is currently in progress
IN_REVIEW: Sprint work is done, demo/review pending
COMPLETED: Sprint has been finished successfully
CANCELLED: Sprint was cancelled before completion
"""
PLANNED = "planned"
ACTIVE = "active"
IN_REVIEW = "in_review"
COMPLETED = "completed"
CANCELLED = "cancelled"

53
backend/app/models/syndarix/issue.py
View File

@@ -6,7 +6,17 @@ An Issue represents a unit of work that can be assigned to agents or humans,
with optional synchronization to external issue trackers (Gitea, GitHub, GitLab).
"""
from sqlalchemy import Column, DateTime, Enum, ForeignKey, Index, Integer, String, Text
from sqlalchemy import (
Column,
Date,
DateTime,
Enum,
ForeignKey,
Index,
Integer,
String,
Text,
)
from sqlalchemy.dialects.postgresql import (
JSONB,
UUID as PGUUID,
@@ -15,7 +25,7 @@ from sqlalchemy.orm import relationship
from app.models.base import Base, TimestampMixin, UUIDMixin
from .enums import IssuePriority, IssueStatus, SyncStatus
from .enums import IssuePriority, IssueStatus, IssueType, SyncStatus
class Issue(Base, UUIDMixin, TimestampMixin):
@@ -39,6 +49,29 @@ class Issue(Base, UUIDMixin, TimestampMixin):
index=True,
)
# Parent issue for hierarchy (Epic -> Story -> Task)
parent_id = Column(
PGUUID(as_uuid=True),
ForeignKey("issues.id", ondelete="CASCADE"),
nullable=True,
index=True,
)
# Issue type (Epic, Story, Task, Bug)
type: Column[IssueType] = Column(
Enum(IssueType),
default=IssueType.TASK,
nullable=False,
index=True,
)
# Reporter (who created this issue - can be user or agent)
reporter_id = Column(
PGUUID(as_uuid=True),
nullable=True, # System-generated issues may have no reporter
index=True,
)
# Issue content
title = Column(String(500), nullable=False)
body = Column(Text, nullable=False, default="")
@@ -83,16 +116,19 @@ class Issue(Base, UUIDMixin, TimestampMixin):
# Story points for estimation
story_points = Column(Integer, nullable=True)
# Due date for the issue
due_date = Column(Date, nullable=True, index=True)
# External tracker integration
external_tracker = Column(
external_tracker_type = Column(
String(50),
nullable=True,
index=True,
) # 'gitea', 'github', 'gitlab'
external_id = Column(String(255), nullable=True) # External system's ID
external_url = Column(String(1000), nullable=True) # Link to external issue
external_number = Column(Integer, nullable=True) # Issue number (e.g., #123)
external_issue_id = Column(String(255), nullable=True) # External system's ID
remote_url = Column(String(1000), nullable=True) # Link to external issue
external_issue_number = Column(Integer, nullable=True) # Issue number (e.g., #123)
# Sync status with external tracker
sync_status: Column[SyncStatus] = Column(
@@ -116,14 +152,17 @@ class Issue(Base, UUIDMixin, TimestampMixin):
foreign_keys=[assigned_agent_id],
)
sprint = relationship("Sprint", back_populates="issues")
parent = relationship("Issue", remote_side="Issue.id", backref="children")
__table_args__ = (
Index("ix_issues_project_status", "project_id", "status"),
Index("ix_issues_project_priority", "project_id", "priority"),
Index("ix_issues_project_sprint", "project_id", "sprint_id"),
Index("ix_issues_external_tracker_id", "external_tracker", "external_id"),
Index("ix_issues_external_tracker_id", "external_tracker_type", "external_issue_id"),
Index("ix_issues_sync_status", "sync_status"),
Index("ix_issues_project_agent", "project_id", "assigned_agent_id"),
Index("ix_issues_project_type", "project_id", "type"),
Index("ix_issues_project_status_priority", "project_id", "status", "priority"),
)
def __repr__(self) -> str:

17
backend/app/models/syndarix/project.py
View File

@@ -15,7 +15,7 @@ from sqlalchemy.orm import relationship
from app.models.base import Base, TimestampMixin, UUIDMixin
from .enums import AutonomyLevel, ProjectStatus
from .enums import AutonomyLevel, ClientMode, ProjectComplexity, ProjectStatus
class Project(Base, UUIDMixin, TimestampMixin):
@@ -48,6 +48,20 @@ class Project(Base, UUIDMixin, TimestampMixin):
index=True,
)
complexity: Column[ProjectComplexity] = Column(
Enum(ProjectComplexity),
default=ProjectComplexity.MEDIUM,
nullable=False,
index=True,
)
client_mode: Column[ClientMode] = Column(
Enum(ClientMode),
default=ClientMode.AUTO,
nullable=False,
index=True,
)
# JSON field for flexible project configuration
# Can include: mcp_servers, webhook_urls, notification_settings, etc.
settings = Column(JSONB, default=dict, nullable=False)
@@ -82,6 +96,7 @@ class Project(Base, UUIDMixin, TimestampMixin):
Index("ix_projects_slug_status", "slug", "status"),
Index("ix_projects_owner_status", "owner_id", "status"),
Index("ix_projects_autonomy_status", "autonomy_level", "status"),
Index("ix_projects_complexity_status", "complexity", "status"),
)
def __repr__(self) -> str:

2
backend/app/models/syndarix/sprint.py
View File

@@ -55,7 +55,7 @@ class Sprint(Base, UUIDMixin, TimestampMixin):
# Progress metrics
planned_points = Column(Integer, nullable=True) # Sum of story points at start
completed_points = Column(Integer, nullable=True) # Sum of completed story points
velocity = Column(Integer, nullable=True) # Sum of completed story points
# Relationships
project = relationship("Project", back_populates="sprints")

2
backend/app/schemas/syndarix/agent_instance.py
View File

@@ -30,6 +30,7 @@ class AgentInstanceCreate(BaseModel):
agent_type_id: UUID
project_id: UUID
name: str = Field(..., min_length=1, max_length=100)
status: AgentStatus = AgentStatus.IDLE
current_task: str | None = None
short_term_memory: dict[str, Any] = Field(default_factory=dict)
@@ -78,6 +79,7 @@ class AgentInstanceResponse(BaseModel):
id: UUID
agent_type_id: UUID
project_id: UUID
name: str
status: AgentStatus
current_task: str | None = None
short_term_memory: dict[str, Any] = Field(default_factory=dict)

24
backend/app/schemas/syndarix/issue.py
View File

@@ -46,10 +46,10 @@ class IssueCreate(IssueBase):
sprint_id: UUID | None = None
# External tracker fields (optional, for importing from external systems)
external_tracker: Literal["gitea", "github", "gitlab"] | None = None
external_id: str | None = Field(None, max_length=255)
external_url: str | None = Field(None, max_length=1000)
external_number: int | None = None
external_tracker_type: Literal["gitea", "github", "gitlab"] | None = None
external_issue_id: str | None = Field(None, max_length=255)
remote_url: str | None = Field(None, max_length=1000)
external_issue_number: int | None = None
class IssueUpdate(BaseModel):
@@ -121,10 +121,10 @@ class IssueInDB(IssueBase):
assigned_agent_id: UUID | None = None
human_assignee: str | None = None
sprint_id: UUID | None = None
external_tracker: str | None = None
external_id: str | None = None
external_url: str | None = None
external_number: int | None = None
external_tracker_type: str | None = None
external_issue_id: str | None = None
remote_url: str | None = None
external_issue_number: int | None = None
sync_status: SyncStatus = SyncStatus.SYNCED
last_synced_at: datetime | None = None
external_updated_at: datetime | None = None
@@ -149,10 +149,10 @@ class IssueResponse(BaseModel):
human_assignee: str | None = None
sprint_id: UUID | None = None
story_points: int | None = None
external_tracker: str | None = None
external_id: str | None = None
external_url: str | None = None
external_number: int | None = None
external_tracker_type: str | None = None
external_issue_id: str | None = None
remote_url: str | None = None
external_issue_number: int | None = None
sync_status: SyncStatus = SyncStatus.SYNCED
last_synced_at: datetime | None = None
external_updated_at: datetime | None = None

10
backend/app/schemas/syndarix/sprint.py
View File

@@ -21,7 +21,7 @@ class SprintBase(BaseModel):
end_date: date
status: SprintStatus = SprintStatus.PLANNED
planned_points: int | None = Field(None, ge=0)
completed_points: int | None = Field(None, ge=0)
velocity: int | None = Field(None, ge=0)
@field_validator("name")
@classmethod
@@ -54,7 +54,7 @@ class SprintUpdate(BaseModel):
end_date: date | None = None
status: SprintStatus | None = None
planned_points: int | None = Field(None, ge=0)
completed_points: int | None = Field(None, ge=0)
velocity: int | None = Field(None, ge=0)
@field_validator("name")
@classmethod
@@ -74,7 +74,7 @@ class SprintStart(BaseModel):
class SprintComplete(BaseModel):
"""Schema for completing a sprint."""
completed_points: int | None = Field(None, ge=0)
velocity: int | None = Field(None, ge=0)
notes: str | None = None
@@ -123,8 +123,8 @@ class SprintVelocity(BaseModel):
sprint_number: int
sprint_name: str
planned_points: int | None
completed_points: int | None
velocity: float | None # completed/planned ratio
velocity: int | None # Sum of completed story points
velocity_ratio: float | None # velocity/planned ratio
class SprintBurndown(BaseModel):

9
backend/app/services/event_bus.py
View File

@@ -81,7 +81,7 @@ class EventBus:
This class provides:
- Event publishing to project/agent-specific channels
- Subscription management for SSE endpoints
- Reconnection support via event IDs and sequence numbers
- Reconnection support via event IDs (Last-Event-ID)
- Keepalive messages for connection health
- Type-safe event creation with the Event schema
@@ -108,7 +108,6 @@ class EventBus:
self._redis_client: redis.Redis | None = None
self._pubsub: redis.client.PubSub | None = None
self._connected = False
self._sequence_counters: dict[str, int] = {}
@property
def redis_client(self) -> redis.Redis:
@@ -239,12 +238,6 @@ class EventBus:
"""
return f"{self.USER_CHANNEL_PREFIX}:{user_id}"
def _get_next_sequence(self, channel: str) -> int:
"""Get the next sequence number for a channel's events."""
current = self._sequence_counters.get(channel, 0)
self._sequence_counters[channel] = current + 1
return current + 1
@staticmethod
def create_event(
event_type: EventType,