cardosofelipe/fast-next-template
Template
1
0
Fork 1
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

fix: Comprehensive validation and bug fixes

Browse Source 
Infrastructure:
- Add Redis and Celery workers to all docker-compose files
- Fix celery migration race condition in entrypoint.sh
- Add healthchecks and resource limits to dev compose
- Update .env.template with Redis/Celery variables

Backend Models & Schemas:
- Rename Sprint.completed_points to velocity (per requirements)
- Add AgentInstance.name as required field
- Rename Issue external tracker fields for consistency
- Add IssueSource and TrackerType enums
- Add Project.default_tracker_type field

Backend Fixes:
- Add Celery retry configuration with exponential backoff
- Remove unused sequence counter from EventBus
- Add mypy overrides for test dependencies
- Fix test file using wrong schema (UserUpdate -> dict)

Frontend Fixes:
- Fix memory leak in useProjectEvents (proper cleanup)
- Fix race condition with stale closure in reconnection
- Sync TokenWithUser type with regenerated API client
- Fix expires_in null handling in useAuth
- Clean up unused imports in prototype pages
- Add ESLint relaxed rules for prototype files

CI/CD:
- Add E2E testing stage with Testcontainers
- Add security scanning with Trivy and pip-audit
- Add dependency caching for faster builds

Tests:
- Update all tests to use renamed fields (velocity, name, etc.)
- Fix 14 schema test failures
- All 1500 tests pass with 91% coverage

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Felipe Cardoso
2025-12-30 10:35:30 +01:00
parent 6ea9edf3d1
commit 742ce4c9c8
57 changed files with 1062 additions and 332 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
backend/tests/models/syndarix/conftest.py
View File

@@ -21,7 +21,6 @@ from app.models.syndarix import (
ProjectStatus,
Sprint,
SprintStatus,
SyncStatus,
)
from app.models.user import User

16
backend/tests/models/syndarix/test_agent_instance.py
View File

@@ -7,8 +7,6 @@ import uuid
from datetime import UTC, datetime
from decimal import Decimal
import pytest
from app.models.syndarix import (
AgentInstance,
AgentStatus,
@@ -45,6 +43,7 @@ class TestAgentInstanceModel:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Alice",
)
db_session.add(instance)
db_session.commit()
@@ -90,6 +89,7 @@ class TestAgentInstanceModel:
id=instance_id,
agent_type_id=agent_type.id,
project_id=project.id,
name="Bob",
status=AgentStatus.WORKING,
current_task="Implementing user authentication",
short_term_memory={"context": "Working on auth", "recent_files": ["auth.py"]},
@@ -132,6 +132,7 @@ class TestAgentInstanceModel:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Charlie",
)
db_session.add(instance)
db_session.commit()
@@ -158,10 +159,12 @@ class TestAgentInstanceModel:
id=instance_id,
agent_type_id=agent_type.id,
project_id=project.id,
name="Dave",
status=AgentStatus.IDLE,
)
repr_str = repr(instance)
assert "Dave" in repr_str
assert str(instance_id) in repr_str
assert str(agent_type.id) in repr_str
assert str(project.id) in repr_str
@@ -185,11 +188,12 @@ class TestAgentInstanceStatus:
db_session.add(agent_type)
db_session.commit()
for status in AgentStatus:
for idx, status in enumerate(AgentStatus):
instance = AgentInstance(
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name=f"Agent-{idx}",
status=status,
)
db_session.add(instance)
@@ -216,6 +220,7 @@ class TestAgentInstanceStatus:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Eve",
status=AgentStatus.IDLE,
)
db_session.add(instance)
@@ -248,6 +253,7 @@ class TestAgentInstanceStatus:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Frank",
status=AgentStatus.WORKING,
current_task="Working on something",
session_id="active-session",
@@ -291,6 +297,7 @@ class TestAgentInstanceMetrics:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Grace",
)
db_session.add(instance)
db_session.commit()
@@ -335,6 +342,7 @@ class TestAgentInstanceMetrics:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Henry",
tokens_used=10_000_000_000, # 10 billion tokens
cost_incurred=Decimal("100000.0000"), # $100,000
)
@@ -381,6 +389,7 @@ class TestAgentInstanceShortTermMemory:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Ivy",
short_term_memory=memory,
)
db_session.add(instance)
@@ -409,6 +418,7 @@ class TestAgentInstanceShortTermMemory:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="Jack",
short_term_memory={"initial": "state"},
)
db_session.add(instance)

52
backend/tests/models/syndarix/test_issue.py
View File

@@ -6,14 +6,13 @@ Unit tests for the Issue model.
import uuid
from datetime import UTC, datetime, timedelta
import pytest
from app.models.syndarix import (
AgentInstance,
AgentType,
Issue,
IssuePriority,
IssueStatus,
IssueType,
Project,
Sprint,
SprintStatus,
@@ -74,15 +73,16 @@ class TestIssueModel:
project_id=project.id,
title="Full Issue",
body="A complete issue with all fields set",
type=IssueType.BUG,
status=IssueStatus.IN_PROGRESS,
priority=IssuePriority.CRITICAL,
labels=["bug", "security", "urgent"],
story_points=8,
human_assignee="john.doe@example.com",
external_tracker="gitea",
external_id="gitea-123",
external_url="https://gitea.example.com/issues/123",
external_number=123,
external_tracker_type="gitea",
external_issue_id="gitea-123",
remote_url="https://gitea.example.com/issues/123",
external_issue_number=123,
sync_status=SyncStatus.SYNCED,
last_synced_at=now,
external_updated_at=now,
@@ -94,14 +94,15 @@ class TestIssueModel:
assert retrieved.title == "Full Issue"
assert retrieved.body == "A complete issue with all fields set"
assert retrieved.type == IssueType.BUG
assert retrieved.status == IssueStatus.IN_PROGRESS
assert retrieved.priority == IssuePriority.CRITICAL
assert retrieved.labels == ["bug", "security", "urgent"]
assert retrieved.story_points == 8
assert retrieved.human_assignee == "john.doe@example.com"
assert retrieved.external_tracker == "gitea"
assert retrieved.external_id == "gitea-123"
assert retrieved.external_number == 123
assert retrieved.external_tracker_type == "gitea"
assert retrieved.external_issue_id == "gitea-123"
assert retrieved.external_issue_number == 123
assert retrieved.sync_status == SyncStatus.SYNCED
def test_issue_timestamps(self, db_session):
@@ -201,8 +202,8 @@ class TestIssueSyncStatus:
id=uuid.uuid4(),
project_id=project.id,
title=f"Issue {sync_status.value}",
external_tracker="gitea",
external_id=f"ext-{sync_status.value}",
external_tracker_type="gitea",
external_issue_id=f"ext-{sync_status.value}",
sync_status=sync_status,
)
db_session.add(issue)
@@ -280,6 +281,7 @@ class TestIssueAssignment:
id=uuid.uuid4(),
agent_type_id=agent_type.id,
project_id=project.id,
name="TaskBot",
)
db_session.add(agent_instance)
db_session.commit()
@@ -368,10 +370,10 @@ class TestIssueExternalTracker:
id=uuid.uuid4(),
project_id=project.id,
title="Gitea Synced Issue",
external_tracker="gitea",
external_id="abc123xyz",
external_url="https://gitea.example.com/org/repo/issues/42",
external_number=42,
external_tracker_type="gitea",
external_issue_id="abc123xyz",
remote_url="https://gitea.example.com/org/repo/issues/42",
external_issue_number=42,
sync_status=SyncStatus.SYNCED,
last_synced_at=now,
external_updated_at=now,
@@ -380,10 +382,10 @@ class TestIssueExternalTracker:
db_session.commit()
retrieved = db_session.query(Issue).filter_by(title="Gitea Synced Issue").first()
assert retrieved.external_tracker == "gitea"
assert retrieved.external_id == "abc123xyz"
assert retrieved.external_number == 42
assert "/issues/42" in retrieved.external_url
assert retrieved.external_tracker_type == "gitea"
assert retrieved.external_issue_id == "abc123xyz"
assert retrieved.external_issue_number == 42
assert "/issues/42" in retrieved.remote_url
def test_github_integration(self, db_session):
"""Test GitHub external tracker fields."""
@@ -395,17 +397,17 @@ class TestIssueExternalTracker:
id=uuid.uuid4(),
project_id=project.id,
title="GitHub Synced Issue",
external_tracker="github",
external_id="gh-12345",
external_url="https://github.com/org/repo/issues/100",
external_number=100,
external_tracker_type="github",
external_issue_id="gh-12345",
remote_url="https://github.com/org/repo/issues/100",
external_issue_number=100,
)
db_session.add(issue)
db_session.commit()
retrieved = db_session.query(Issue).filter_by(title="GitHub Synced Issue").first()
assert retrieved.external_tracker == "github"
assert retrieved.external_number == 100
assert retrieved.external_tracker_type == "github"
assert retrieved.external_issue_number == 100
class TestIssueLifecycle:

26
backend/tests/models/syndarix/test_sprint.py
View File

@@ -50,7 +50,7 @@ class TestSprintModel:
assert retrieved.status == SprintStatus.PLANNED # Default
assert retrieved.goal is None
assert retrieved.planned_points is None
assert retrieved.completed_points is None
assert retrieved.velocity is None
def test_create_sprint_with_all_fields(self, db_session):
"""Test creating a sprint with all optional fields."""
@@ -75,7 +75,7 @@ class TestSprintModel:
end_date=today + timedelta(days=14),
status=SprintStatus.ACTIVE,
planned_points=34,
completed_points=21,
velocity=21,
)
db_session.add(sprint)
db_session.commit()
@@ -87,7 +87,7 @@ class TestSprintModel:
assert retrieved.goal == "Complete all authentication features"
assert retrieved.status == SprintStatus.ACTIVE
assert retrieved.planned_points == 34
assert retrieved.completed_points == 21
assert retrieved.velocity == 21
def test_sprint_timestamps(self, db_session):
"""Test that timestamps are automatically set."""
@@ -214,12 +214,12 @@ class TestSprintLifecycle:
# Complete the sprint
sprint.status = SprintStatus.COMPLETED
sprint.completed_points = 18
sprint.velocity = 18
db_session.commit()
retrieved = db_session.query(Sprint).filter_by(name="Sprint to Complete").first()
assert retrieved.status == SprintStatus.COMPLETED
assert retrieved.completed_points == 18
assert retrieved.velocity == 18
def test_cancel_sprint(self, db_session):
"""Test cancelling a sprint."""
@@ -338,14 +338,14 @@ class TestSprintPoints:
start_date=today,
end_date=today + timedelta(days=14),
planned_points=0,
completed_points=0,
velocity=0,
)
db_session.add(sprint)
db_session.commit()
retrieved = db_session.query(Sprint).filter_by(name="Zero Points Sprint").first()
assert retrieved.planned_points == 0
assert retrieved.completed_points == 0
assert retrieved.velocity == 0
def test_sprint_velocity_calculation(self, db_session):
"""Test that we can calculate velocity from points."""
@@ -363,16 +363,16 @@ class TestSprintPoints:
end_date=today + timedelta(days=14),
status=SprintStatus.COMPLETED,
planned_points=21,
completed_points=18,
velocity=18,
)
db_session.add(sprint)
db_session.commit()
retrieved = db_session.query(Sprint).filter_by(name="Velocity Sprint").first()
# Calculate velocity
velocity = retrieved.completed_points / retrieved.planned_points
assert velocity == pytest.approx(18 / 21, rel=0.01)
# Calculate completion ratio from velocity
completion_ratio = retrieved.velocity / retrieved.planned_points
assert completion_ratio == pytest.approx(18 / 21, rel=0.01)
def test_sprint_overdelivery(self, db_session):
"""Test sprint where completed > planned (stretch goals)."""
@@ -390,13 +390,13 @@ class TestSprintPoints:
end_date=today + timedelta(days=14),
status=SprintStatus.COMPLETED,
planned_points=20,
completed_points=25, # Completed more than planned
velocity=25, # Completed more than planned
)
db_session.add(sprint)
db_session.commit()
retrieved = db_session.query(Sprint).filter_by(name="Overdelivery Sprint").first()
assert retrieved.completed_points > retrieved.planned_points
assert retrieved.velocity > retrieved.planned_points
class TestSprintNumber: