From db868c53c6474a5d3dea87cf33dac49ad74b603d Mon Sep 17 00:00:00 2001 From: Felipe Cardoso Date: Wed, 31 Dec 2025 11:18:05 +0100 Subject: [PATCH] fix(frontend): Fix lint and type errors in test files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove unused imports (fireEvent, IssueStatus) in issue component tests - Add E2E global type declarations for __TEST_AUTH_STORE__ - Fix toHaveAccessibleName assertion with regex pattern 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- frontend/e2e/global.d.ts | 18 ++++++++++++++++++ frontend/e2e/issues.spec.ts | 2 +- .../issues/components/IssueFilters.test.tsx | 2 +- .../issues/components/IssueTable.test.tsx | 2 +- .../issues/components/StatusWorkflow.test.tsx | 1 - 5 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 frontend/e2e/global.d.ts diff --git a/frontend/e2e/global.d.ts b/frontend/e2e/global.d.ts new file mode 100644 index 0000000..eb91302 --- /dev/null +++ b/frontend/e2e/global.d.ts @@ -0,0 +1,18 @@ +/** + * Global type declarations for E2E tests + */ + +declare global { + interface Window { + __TEST_AUTH_STORE__?: { + getState: () => { + isAuthenticated: boolean; + user: { id: string; email: string; is_superuser: boolean } | null; + accessToken: string | null; + refreshToken: string | null; + }; + }; + } +} + +export {}; diff --git a/frontend/e2e/issues.spec.ts b/frontend/e2e/issues.spec.ts index ade63c3..f0a6a29 100644 --- a/frontend/e2e/issues.spec.ts +++ b/frontend/e2e/issues.spec.ts @@ -238,7 +238,7 @@ test.describe('Issue Management', () => { expect(count).toBeGreaterThan(0); // First checkbox should have accessible label - await expect(checkboxes.first()).toHaveAccessibleName(); + await expect(checkboxes.first()).toHaveAccessibleName(/.+/); }); test('issue detail has proper radiogroup for status', async ({ page }) => { diff --git a/frontend/tests/features/issues/components/IssueFilters.test.tsx b/frontend/tests/features/issues/components/IssueFilters.test.tsx index 7739870..c8c10b8 100644 --- a/frontend/tests/features/issues/components/IssueFilters.test.tsx +++ b/frontend/tests/features/issues/components/IssueFilters.test.tsx @@ -2,7 +2,7 @@ * IssueFilters Component Tests */ -import { render, screen, fireEvent } from '@testing-library/react'; +import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { IssueFilters } from '@/features/issues/components/IssueFilters'; import type { IssueFilters as IssueFiltersType } from '@/features/issues/types'; diff --git a/frontend/tests/features/issues/components/IssueTable.test.tsx b/frontend/tests/features/issues/components/IssueTable.test.tsx index 8a0f831..9d630f7 100644 --- a/frontend/tests/features/issues/components/IssueTable.test.tsx +++ b/frontend/tests/features/issues/components/IssueTable.test.tsx @@ -2,7 +2,7 @@ * IssueTable Component Tests */ -import { render, screen, fireEvent } from '@testing-library/react'; +import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { IssueTable } from '@/features/issues/components/IssueTable'; import type { IssueSummary, IssueSort } from '@/features/issues/types'; diff --git a/frontend/tests/features/issues/components/StatusWorkflow.test.tsx b/frontend/tests/features/issues/components/StatusWorkflow.test.tsx index 2a64a85..532038f 100644 --- a/frontend/tests/features/issues/components/StatusWorkflow.test.tsx +++ b/frontend/tests/features/issues/components/StatusWorkflow.test.tsx @@ -5,7 +5,6 @@ import { render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { StatusWorkflow } from '@/features/issues/components/StatusWorkflow'; -import type { IssueStatus } from '@/features/issues/types'; describe('StatusWorkflow', () => { const mockOnStatusChange = jest.fn();