From 1b5b193e81d87c170be2040ec20562b85d6d82b7 Mon Sep 17 00:00:00 2001 From: Felipe Cardoso Date: Thu, 26 Mar 2026 22:38:48 +0100 Subject: [PATCH] fix: suppress exit code 143 from metric logger cleanup The metric logger is killed via SIGTERM on benchmark completion, producing exit code 143 (128+15) which propagated through set -e. Added explicit return 0 / trailing true to cleanup traps. Co-Authored-By: Claude Opus 4.6 (1M context) --- scripts/benchmark/run-baseline.sh | 1 + scripts/benchmark/run-suite.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/benchmark/run-baseline.sh b/scripts/benchmark/run-baseline.sh index 1261e86..40ff8ae 100644 --- a/scripts/benchmark/run-baseline.sh +++ b/scripts/benchmark/run-baseline.sh @@ -148,6 +148,7 @@ log_info "Metric logger started (PID: $METRICS_PID)" cleanup() { kill "$METRICS_PID" 2>/dev/null || true wait "$METRICS_PID" 2>/dev/null || true + return 0 } trap cleanup EXIT diff --git a/scripts/benchmark/run-suite.sh b/scripts/benchmark/run-suite.sh index 067679f..ebca5c0 100644 --- a/scripts/benchmark/run-suite.sh +++ b/scripts/benchmark/run-suite.sh @@ -136,7 +136,7 @@ log_info "Models: ${#MODEL_PATHS[@]}" METRICS_FILE="$RESULT_DIR/metrics.csv" bash "$SCRIPT_DIR/../monitor/log-metrics.sh" --output "$METRICS_FILE" --interval 2 & METRICS_PID=$! -trap 'kill "$METRICS_PID" 2>/dev/null; wait "$METRICS_PID" 2>/dev/null' EXIT +trap 'kill "$METRICS_PID" 2>/dev/null; wait "$METRICS_PID" 2>/dev/null; true' EXIT # Run benchmarks (same logic as run-baseline.sh) for MODEL_PATH in "${MODEL_PATHS[@]}"; do