fix: address code review findings (HIGH + MEDIUM)

- Replace GNU \b with portable word-boundary sed patterns in kernel-params
- Warn on unknown CLI arguments instead of silently swallowing
- Add floor check on recommended_gttsize_mib to prevent negative values
- Fix Python operator precedence in benchmark log parser
- Add root checks to tuned-profile.sh and rollback.sh
- Remove redundant sudo calls (scripts already require root at entry)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felipe Cardoso
2026-03-25 20:19:44 +01:00
parent c596e38e9e
commit af0515d05d
7 changed files with 24 additions and 12 deletions

View File

@@ -93,12 +93,12 @@ with open(os.environ["GRUB_PATH"]) as f:
print("")
')"
# Remove any existing values of these params
# Remove any existing values of these params (portable, no GNU \b)
new_cmdline="$current_cmdline"
new_cmdline="$(echo "$new_cmdline" | sed -E 's/\biommu=[^ ]*//g')"
new_cmdline="$(echo "$new_cmdline" | sed -E 's/\bamd_iommu=[^ ]*//g')"
new_cmdline="$(echo "$new_cmdline" | sed -E 's/\bamdgpu\.gttsize=[^ ]*//g')"
new_cmdline="$(echo "$new_cmdline" | sed -E 's/\bttm\.pages_limit=[^ ]*//g')"
new_cmdline="$(echo " $new_cmdline " | sed -E 's/ iommu=[^ ]*/ /g')"
new_cmdline="$(echo " $new_cmdline " | sed -E 's/ amd_iommu=[^ ]*/ /g')"
new_cmdline="$(echo " $new_cmdline " | sed -E 's/ amdgpu\.gttsize=[^ ]*/ /g')"
new_cmdline="$(echo " $new_cmdline " | sed -E 's/ ttm\.pages_limit=[^ ]*/ /g')"
# Clean up extra spaces
new_cmdline="$(echo "$new_cmdline" | xargs)"

View File

@@ -10,6 +10,11 @@ BACKUP_DIR="$(data_dir backups)"
log_header "Rollback Optimizations"
if [[ $EUID -ne 0 ]]; then
log_error "This script requires root. Re-run with: sudo make rollback"
exit 1
fi
# ── 1. GRUB rollback ────────────────────────────────────
log_info "GRUB backups:"
mapfile -t grub_backups < <(find "$BACKUP_DIR" -name 'grub-*.bak' -print 2>/dev/null | sort -r)
@@ -23,7 +28,7 @@ else
echo ""
if confirm "Restore most recent GRUB backup?"; then
require_root
# root already checked at script start
backup="${grub_backups[0]}"
cp "$backup" "$GRUB_FILE"
log_success "GRUB restored from: $backup"
@@ -54,7 +59,7 @@ if [[ -f "$prev_profile_file" ]]; then
log_info "Tuned profile: $current (previous: $prev_profile)"
if [[ "$current" != "$prev_profile" ]] && confirm "Restore tuned profile to $prev_profile?"; then
sudo tuned-adm profile "$prev_profile"
tuned-adm profile "$prev_profile"
log_success "Tuned profile restored to: $prev_profile"
fi
else

View File

@@ -10,6 +10,11 @@ RECOMMENDED="accelerator-performance"
log_header "Tuned Profile Optimization"
if [[ $EUID -ne 0 ]]; then
log_error "This script requires root. Re-run with: sudo make optimize-tuned"
exit 1
fi
if ! is_cmd tuned-adm; then
log_error "tuned is not installed. Install with: sudo dnf install tuned"
exit 1
@@ -46,7 +51,7 @@ fi
# Save current for rollback
echo "$current" > "$(data_dir backups)/tuned-previous-profile.txt"
sudo tuned-adm profile "$RECOMMENDED"
tuned-adm profile "$RECOMMENDED"
new_profile="$(detect_tuned_profile)"
if [[ "$new_profile" == "$RECOMMENDED" ]]; then