fix(memory): address review findings from Issue #88

Fixes based on multi-agent review:

Model Improvements:
- Remove duplicate index ix_procedures_agent_type (already indexed via Column)
- Fix postgresql_where to use text() instead of string literal in Fact model
- Add thread-safety to Procedure.success_rate property (snapshot values)

Data Integrity Constraints:
- Add CheckConstraint for Episode: importance_score 0-1, duration >= 0, tokens >= 0
- Add CheckConstraint for Fact: confidence 0-1
- Add CheckConstraint for Procedure: success_count >= 0, failure_count >= 0

Migration Updates:
- Add check constraints creation in upgrade()
- Add check constraints removal in downgrade()

Note: SQLAlchemy Column default=list is correct (callable factory pattern)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2026-01-05 01:54:51 +01:00
parent 4974233169
commit bd988f76b0
4 changed files with 88 additions and 5 deletions

View File

@@ -7,6 +7,7 @@ triple format with confidence scores and source tracking.
"""
from sqlalchemy import (
CheckConstraint,
Column,
DateTime,
Float,
@@ -15,6 +16,7 @@ from sqlalchemy import (
Integer,
String,
Text,
text,
)
from sqlalchemy.dialects.postgresql import (
ARRAY,
@@ -86,7 +88,7 @@ class Fact(Base, UUIDMixin, TimestampMixin):
"predicate",
"object",
unique=True,
postgresql_where="project_id IS NOT NULL",
postgresql_where=text("project_id IS NOT NULL"),
),
# Query patterns
Index("ix_facts_subject_predicate", "subject", "predicate"),
@@ -94,6 +96,11 @@ class Fact(Base, UUIDMixin, TimestampMixin):
Index("ix_facts_confidence_time", "confidence", "last_reinforced"),
# For finding facts by entity (subject or object)
Index("ix_facts_subject", "subject"),
# Data integrity constraints
CheckConstraint(
"confidence >= 0.0 AND confidence <= 1.0",
name="ck_facts_confidence_range",
),
)
def __repr__(self) -> str: