diff --git a/frontend/e2e/settings-navigation.spec.ts b/frontend/e2e/settings-navigation.spec.ts index 2b23cd1..6e18a9c 100644 --- a/frontend/e2e/settings-navigation.spec.ts +++ b/frontend/e2e/settings-navigation.spec.ts @@ -1,19 +1,82 @@ /** * E2E Tests for Settings Navigation - * - * PLACEHOLDER: Settings tests require authenticated state. - * Future implementation options: - * 1. Add full login mock chain to setupAuthenticatedMocks() - * 2. Use real backend in E2E (recommended for settings tests) - * 3. Add test-only auth endpoint - * - * Current baseline: 47 passing E2E tests covering all auth flows + * Tests navigation between settings pages */ -import { test } from '@playwright/test'; +import { test, expect } from '@playwright/test'; +import { setupAuthenticatedMocks, loginViaUI } from './helpers/auth'; test.describe('Settings Navigation', () => { - test.skip('Placeholder - requires authenticated state setup', async () => { - // Skipped during nuclear refactor - auth flow tests cover critical paths + test.beforeEach(async ({ page }) => { + // Set up API mocks + await setupAuthenticatedMocks(page); + + // Login via UI to establish authenticated session + await loginViaUI(page); + }); + + test('should navigate from home to settings profile', async ({ page }) => { + // From home page + await expect(page).toHaveURL('/'); + + // Navigate to settings/profile + await page.goto('/settings/profile'); + + // Verify navigation successful + await expect(page).toHaveURL('/settings/profile'); + + // Verify page loaded + await expect(page.locator('h2')).toContainText('Profile'); + }); + + test('should navigate from home to settings password', async ({ page }) => { + // From home page + await expect(page).toHaveURL('/'); + + // Navigate to settings/password + await page.goto('/settings/password'); + + // Verify navigation successful + await expect(page).toHaveURL('/settings/password'); + + // Verify page loaded + await expect(page.locator('h2')).toContainText('Password'); + }); + + test('should navigate between settings pages', async ({ page }) => { + // Start at profile page + await page.goto('/settings/profile'); + await expect(page.locator('h2')).toContainText('Profile'); + + // Navigate to password page + await page.goto('/settings/password'); + await expect(page.locator('h2')).toContainText('Password'); + + // Navigate back to profile page + await page.goto('/settings/profile'); + await expect(page.locator('h2')).toContainText('Profile'); + }); + + test('should redirect from /settings to /settings/profile', async ({ page }) => { + // Navigate to base settings page + await page.goto('/settings'); + + // Should redirect to profile page + await expect(page).toHaveURL('/settings/profile'); + + // Verify profile page loaded + await expect(page.locator('h2')).toContainText('Profile'); + }); + + test('should display preferences page placeholder', async ({ page }) => { + // Navigate to preferences page + await page.goto('/settings/preferences'); + + // Verify navigation successful + await expect(page).toHaveURL('/settings/preferences'); + + // Verify page loaded with placeholder content + await expect(page.locator('h2')).toContainText('Preferences'); + await expect(page.getByText(/coming in task/i)).toBeVisible(); }); }); diff --git a/frontend/e2e/settings-password.spec.ts b/frontend/e2e/settings-password.spec.ts index 36545ef..3fea990 100644 --- a/frontend/e2e/settings-password.spec.ts +++ b/frontend/e2e/settings-password.spec.ts @@ -1,24 +1,60 @@ /** * E2E Tests for Password Change Page - * - * DELETED: All password change tests were failing due to auth state issues after - * architecture simplification. These tests will be rebuilt in Phase 3 with a - * pragmatic approach combining actual login flow and direct auth store injection. - * - * Tests to rebuild: - * - Display password change form - * - Show password strength requirements - * - Validation for weak passwords - * - Validation for mismatched passwords - * - Password input types - * - Successfully change password + * Tests password change functionality */ -import { test } from '@playwright/test'; +import { test, expect } from '@playwright/test'; +import { setupAuthenticatedMocks, loginViaUI } from './helpers/auth'; test.describe('Password Change', () => { - test.skip('Placeholder - tests will be rebuilt in Phase 3', async () => { - // Tests deleted during nuclear refactor Phase 2 - // Will be rebuilt with pragmatic auth approach + test.beforeEach(async ({ page }) => { + // Set up API mocks + await setupAuthenticatedMocks(page); + + // Login via UI to establish authenticated session + await loginViaUI(page); + + // Navigate to password page + await page.goto('/settings/password'); + + // Wait for page to render + await page.waitForTimeout(1000); + }); + + test('should display password change form', async ({ page }) => { + // Check page title + await expect(page.locator('h2')).toContainText('Password'); + + // Wait for form to be visible + const currentPasswordInput = page.getByLabel(/current password/i); + await currentPasswordInput.waitFor({ state: 'visible', timeout: 10000 }); + + // Verify all password fields are present + await expect(currentPasswordInput).toBeVisible(); + await expect(page.getByLabel(/^new password/i)).toBeVisible(); + await expect(page.getByLabel(/confirm.*password/i)).toBeVisible(); + + // Verify submit button is present + await expect(page.getByRole('button', { name: /change password/i })).toBeVisible(); + }); + + test('should have all password fields as password type', async ({ page }) => { + // Wait for form to load + const currentPasswordInput = page.getByLabel(/current password/i); + await currentPasswordInput.waitFor({ state: 'visible', timeout: 10000 }); + + // Verify all password fields have type="password" + await expect(currentPasswordInput).toHaveAttribute('type', 'password'); + await expect(page.getByLabel(/^new password/i)).toHaveAttribute('type', 'password'); + await expect(page.getByLabel(/confirm.*password/i)).toHaveAttribute('type', 'password'); + }); + + test('should have submit button disabled initially', async ({ page }) => { + // Wait for form to load + const submitButton = page.getByRole('button', { name: /change password/i }); + await submitButton.waitFor({ state: 'visible', timeout: 10000 }); + + // Verify button is disabled when form is empty/untouched + await expect(submitButton).toBeDisabled(); }); }); diff --git a/frontend/e2e/settings-profile.spec.ts b/frontend/e2e/settings-profile.spec.ts index da0b584..961e9a9 100644 --- a/frontend/e2e/settings-profile.spec.ts +++ b/frontend/e2e/settings-profile.spec.ts @@ -34,4 +34,16 @@ test.describe('Profile Settings', () => { await expect(page.getByLabel(/last name/i)).toHaveValue(MOCK_USER.last_name); await expect(page.getByLabel(/email/i)).toHaveValue(MOCK_USER.email); }); + + test('should show email as read-only', async ({ page }) => { + // Wait for form to load + const emailInput = page.getByLabel(/email/i); + await emailInput.waitFor({ state: 'visible', timeout: 10000 }); + + // Verify email field is disabled or read-only + const isDisabled = await emailInput.isDisabled(); + const isReadOnly = await emailInput.getAttribute('readonly'); + + expect(isDisabled || isReadOnly !== null).toBeTruthy(); + }); }); diff --git a/frontend/e2e/settings-sessions.spec.ts b/frontend/e2e/settings-sessions.spec.ts index 829bb6c..8de41fe 100644 --- a/frontend/e2e/settings-sessions.spec.ts +++ b/frontend/e2e/settings-sessions.spec.ts @@ -1,23 +1,20 @@ /** * E2E Tests for Sessions Management Page * - * DELETED: All 12 tests were failing due to auth state loss on navigation. - * These tests will be rebuilt in Phase 3 with a focus on user behavior - * and using the simplified auth architecture. + * SKIPPED: Tests fail because /settings/sessions route redirects to login. + * This indicates either: + * 1. The route doesn't exist in the current implementation + * 2. The route has different auth requirements + * 3. The route needs to be implemented * - * Tests to rebuild: - * - User can view active sessions - * - User can revoke a non-current session - * - User cannot revoke current session - * - Bulk revoke confirmation dialog + * These tests should be re-enabled once the sessions page is confirmed to exist. */ -import { test, expect } from '@playwright/test'; -import { setupAuthenticatedMocks } from './helpers/auth'; +import { test } from '@playwright/test'; test.describe('Sessions Management', () => { - test.skip('Placeholder - tests will be rebuilt in Phase 3', async ({ page }) => { - // Tests deleted during nuclear refactor - // Will be rebuilt with simplified auth architecture + test.skip('Placeholder - route /settings/sessions redirects to login', async () => { + // Tests skipped because navigation to /settings/sessions fails auth + // Verify route exists before re-enabling these tests }); }); diff --git a/frontend/playwright.config.ts b/frontend/playwright.config.ts index 21b586a..9246458 100644 --- a/frontend/playwright.config.ts +++ b/frontend/playwright.config.ts @@ -18,7 +18,7 @@ export default defineConfig({ /* Retry on CI and locally to handle flaky tests */ retries: process.env.CI ? 2 : 1, /* Use 1 worker to prevent test interference (parallel execution causes auth mock conflicts) */ - workers: 1, + workers: process.env.CI ? 1 : 8, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ reporter: process.env.CI ? 'github' : 'list', /* Suppress console output unless VERBOSE=true */