fix(mcp-kb): Add missing /mcp JSON-RPC endpoint for tool execution #74

New Issue

cardosofelipe · 2026-01-03T23:57:02Z

cardosofelipe commented

2026-01-03 23:57:02 +00:00

Bug Description

The Knowledge Base MCP server is missing the /mcp endpoint required by the backend MCP client infrastructure. Without this endpoint, the backend cannot execute KB tools via JSON-RPC 2.0.

Expected Endpoints (per backend MCP client)

GET /health - ✅ Exists
GET /mcp/tools - ❌ Missing
POST /mcp - ❌ Missing (this issue)

Location

mcp-servers/knowledge-base/server.py

Required Implementation

@app.post("/mcp")
async def mcp_rpc(request: Request):
    """JSON-RPC 2.0 endpoint for tool execution."""
    body = await request.json()
    # Validate JSON-RPC format
    # Route to appropriate tool
    # Return JSON-RPC response

Protocol

Must follow JSON-RPC 2.0 specification:

// Request
{"jsonrpc": "2.0", "method": "search_knowledge", "params": {...}, "id": 1}

// Response
{"jsonrpc": "2.0", "result": {...}, "id": 1}

Found during PR #72 deep review
Issue #57 (Knowledge Base MCP Server)
Companion issue for /mcp/tools endpoint

## Bug Description The Knowledge Base MCP server is missing the `/mcp` endpoint required by the backend MCP client infrastructure. Without this endpoint, the backend cannot execute KB tools via JSON-RPC 2.0. ### Expected Endpoints (per backend MCP client) - `GET /health` - ✅ Exists - `GET /mcp/tools` - ❌ Missing - `POST /mcp` - ❌ Missing (this issue) ### Location `mcp-servers/knowledge-base/server.py` ### Required Implementation ```python @app.post("/mcp") async def mcp_rpc(request: Request): """JSON-RPC 2.0 endpoint for tool execution.""" body = await request.json() # Validate JSON-RPC format # Route to appropriate tool # Return JSON-RPC response ``` ### Protocol Must follow JSON-RPC 2.0 specification: ```json // Request {"jsonrpc": "2.0", "method": "search_knowledge", "params": {...}, "id": 1} // Response {"jsonrpc": "2.0", "result": {...}, "id": 1} ``` ### Related - Found during PR #72 deep review - Issue #57 (Knowledge Base MCP Server) - Companion issue for /mcp/tools endpoint

cardosofelipe closed this issue

2026-01-04 00:03:42 +00:00

cardosofelipe referenced this issue from a commit

2026-01-04 00:08:59 +00:00

fix(mcp-kb): address critical issues from deep review

~~cardosofelipe referenced this issue 2026-01-04 00:50:16 +00:00~~

feat(mcp): Context Management Engine #61

Sign in to join this conversation.