cardosofelipe/strix-halo-optimizations
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: suppress exit code 143 from metric logger cleanup

Browse Source 
The metric logger is killed via SIGTERM on benchmark completion, producing
exit code 143 (128+15) which propagated through set -e. Added explicit
return 0 / trailing true to cleanup traps.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felipe Cardoso
2026-03-26 22:38:48 +01:00
parent fb1e57f1bf
commit 1b5b193e81
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
scripts/benchmark/run-baseline.sh
View File

@@ -148,6 +148,7 @@ log_info "Metric logger started (PID: $METRICS_PID)"
cleanup() { cleanup() {
kill "$METRICS_PID" 2>/dev/null || true kill "$METRICS_PID" 2>/dev/null || true
wait "$METRICS_PID" 2>/dev/null || true wait "$METRICS_PID" 2>/dev/null || true
return 0
} }
trap cleanup EXIT trap cleanup EXIT

2
scripts/benchmark/run-suite.sh
View File

@@ -136,7 +136,7 @@ log_info "Models: ${#MODEL_PATHS[@]}"
METRICS_FILE="$RESULT_DIR/metrics.csv" METRICS_FILE="$RESULT_DIR/metrics.csv"
bash "$SCRIPT_DIR/../monitor/log-metrics.sh" --output "$METRICS_FILE" --interval 2 & bash "$SCRIPT_DIR/../monitor/log-metrics.sh" --output "$METRICS_FILE" --interval 2 &
METRICS_PID=$! METRICS_PID=$!
trap 'kill "$METRICS_PID" 2>/dev/null; wait "$METRICS_PID" 2>/dev/null' EXIT trap 'kill "$METRICS_PID" 2>/dev/null; wait "$METRICS_PID" 2>/dev/null; true' EXIT
# Run benchmarks (same logic as run-baseline.sh) # Run benchmarks (same logic as run-baseline.sh)
for MODEL_PATH in "${MODEL_PATHS[@]}"; do for MODEL_PATH in "${MODEL_PATHS[@]}"; do